Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Awesomebar autocomplete may fail to show history suggestions #12711

Closed
Mugurell opened this issue Aug 29, 2022 · 1 comment · Fixed by #12712 or nathanmkaya/android-components#362
Closed

Awesomebar autocomplete may fail to show history suggestions #12711

Mugurell opened this issue Aug 29, 2022 · 1 comment · Fixed by #12712 or nathanmkaya/android-components#362
Assignees
@Mugurell
Labels
<awesomebar> Components: compose-awesomebar, feature-awesomebar, concept-awesomebar
Milestone
106.0.0 ⛈

Comments

@Mugurell
Copy link
Contributor

Mugurell commented Aug 29, 2022 •
edited by data-sync-user
Loading

Issue seen in mozilla-mobile/fenix#26687 and reported as intermittent.

Debugging I indeed saw cases in which the getAutocompleteSuggestion from ToolbarAutocompleteFeature will return null and so the app will show results from the shipped in domain providers.

My working theory is that the interrupted reads for history suggestions

android-components/components/feature/awesomebar/src/main/java/mozilla/components/feature/awesomebar/provider/HistoryStorageSuggestionProvider.kt

Line 57 in 52e2fc7

historyStorage.cancelReads()
are in a race with the autocomplete suggestions which use the same reader.

┆Issue is synchronized with this Jira Task
@Mugurell Mugurell added the <awesomebar> Components: compose-awesomebar, feature-awesomebar, concept-awesomebar label Aug 29, 2022
@Mugurell Mugurell self-assigned this Aug 29, 2022
Mugurell added a commit to Mugurell/android-components that referenced this issue Aug 29, 2022
@Mugurell
For mozilla-mobile#12711 - Use a separate reader for autocomplete sug…
ebb4f23 
…gestions

Decouple this functionality from search suggestions allowing for individual
control over the readers used.
@github-actions github-actions bot mentioned this issue Aug 29, 2022
Merged
4 tasks
mergify bot pushed a commit that referenced this issue Aug 30, 2022
@Mugurell @mergify
For #12711 - Use a separate reader for autocomplete suggestions
2026625 
Decouple this functionality from search suggestions allowing for individual
control over the readers used.
@mergify mergify bot closed this as completed in #12712 Aug 30, 2022
@github-actions github-actions bot added this to the 106.0.0 ⛈ milestone Aug 30, 2022
mergify bot pushed a commit that referenced this issue Sep 1, 2022
@Mugurell @mergify
For #12711 - Use a separate reader for autocomplete suggestions
3499065 
Decouple this functionality from search suggestions allowing for individual
control over the readers used.

(cherry picked from commit 2026625)

# Conflicts:
#	docs/changelog.md
Mugurell added a commit that referenced this issue Sep 1, 2022
@Mugurell
For #12711 - Use a separate reader for autocomplete suggestions
4777d18 
Decouple this functionality from search suggestions allowing for individual
control over the readers used.

(cherry picked from commit 2026625)

# Conflicts resolved:
#	docs/changelog.md
@rvandermeulen
Copy link
Contributor

For 105, this will be in the Fenix 105.0b4 build.

mergify bot pushed a commit that referenced this issue Sep 1, 2022
@Mugurell @mergify
For #12711 - Use a separate reader for autocomplete suggestions
f6da143 
Decouple this functionality from search suggestions allowing for individual
control over the readers used.

(cherry picked from commit 2026625)

# Conflicts resolved:
#	docs/changelog.md
mergify bot pushed a commit that referenced this issue Sep 5, 2022
@Mugurell @mergify
For #12711 - Use a separate reader for autocomplete suggestions
deadaf3 
Decouple this functionality from search suggestions allowing for individual
control over the readers used.

(cherry picked from commit 2026625)

# Conflicts:
#	docs/changelog.md
Mugurell added a commit that referenced this issue Sep 5, 2022
@Mugurell
For #12711 - Use a separate reader for autocomplete suggestions
95a5435 
Decouple this functionality from search suggestions allowing for individual
control over the readers used.

(cherry picked from commit 2026625)

# Conflicts resolved:
#	docs/changelog.md
mergify bot pushed a commit that referenced this issue Sep 5, 2022
@Mugurell @mergify
For #12711 - Use a separate reader for autocomplete suggestions
a662769 
Decouple this functionality from search suggestions allowing for individual
control over the readers used.

(cherry picked from commit 2026625)

# Conflicts resolved:
#	docs/changelog.md
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Sep 7, 2022
@Mugurell @mergify
[components] For mozilla-mobile/android-components#12711 - Use a sepa…
5d13893 
…rate reader for autocomplete suggestions

Decouple this functionality from search suggestions allowing for individual
control over the readers used.
@github-actions github-actions bot mentioned this issue Oct 26, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Mugurell Mugurell

Labels
<awesomebar> Components: compose-awesomebar, feature-awesomebar, concept-awesomebar
Projects
None yet
Milestone
106.0.0 ⛈
2 participants
@rvandermeulen @Mugurell