Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Allow to distinguish between main process and other process crashes in GleanCrashReporter #6013

Closed
wcbeard opened this issue Feb 20, 2020 · 3 comments
Labels
<crash> Component: lib-crash

Comments

@wcbeard
Copy link

wcbeard commented Feb 20, 2020

#5175 made process type information available to CrashReporterService.

In order to be able to monitor a representative sample of crash rates in Fenix, it will be useful to have the process type recorded in Glean.

Incorporating this process info into the crash counts as currently implemented may require changing the existing format.

cc @travis79

┆Issue is synchronized with this Jira Task

@travis79 travis79 changed the title Allow to distinguish between main process and other process crashes in Glean Allow to distinguish between main process and other process crashes in GleanCrashReporter Feb 21, 2020
@travis79 travis79 added the <crash> Component: lib-crash label Feb 21, 2020
@travis79
Copy link
Member

travis79 commented Feb 21, 2020

@wcbeard, I apologize for editing your title, but I wanted to make it clear what needed changed was in the GleanCrashReporter part of the lib-crash component and not in the Glean component.

@travis79
Copy link
Member

travis79 commented Mar 4, 2020

It looks like @rocketsroger has already taken care of this via the issue #5175 that was referenced. One of the commits/PR's associated with that split the native_code_crash labeled counter into fatal_native_code_crash (main process crash) and nonfatal_native_code_crash (content process crash).

I don’t think that there is any further work to do here, unless I’m mistaken.

@rocketsroger
Copy link
Contributor

Confirmed. This has been implemented by #5175. Closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
<crash> Component: lib-crash
Projects
None yet
Development

No branches or pull requests

3 participants