Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Crash reporter: Allow to distinguish between main process and other process crashes. #5175

Closed
pocmo opened this issue Nov 27, 2019 · 4 comments
Assignees
Labels
<crash> Component: lib-crash E5 Estimation points: 5 🌟 feature New functionality and improvements
Milestone

Comments

@pocmo
Copy link
Contributor

pocmo commented Nov 27, 2019

To measure stability and compare with Fennec we want to know whether a crash happened in the main process (and therefore takes down the whole app) or whether it happened in another process (e.g. the content process).

┆Issue is synchronized with this Jira Task

@pocmo pocmo added 🌟 feature New functionality and improvements <crash> Component: lib-crash labels Nov 27, 2019
@liuche liuche added must and removed must labels Dec 30, 2019
@liuche
Copy link
Contributor

liuche commented Dec 30, 2019

@st3fan do you have thoughts on whether this and #5174 should be done by eng on AC or Fenix teams? I know we're going to talk about it soon as a group, so just want to make sure I add the right people from my team if needed.

@snorp
Copy link
Contributor

snorp commented Jan 7, 2020

Not sure if folks are aware or not, but GV delivers this in the crash service intent. https://searchfox.org/mozilla-central/source/mobile/android/geckoview_example/src/main/java/org/mozilla/geckoview_example/ExampleCrashHandler.java#49

@rocketsroger rocketsroger self-assigned this Jan 7, 2020
@rocketsroger rocketsroger added the E3 Estimation points: 3 label Jan 8, 2020
rocketsroger added a commit to rocketsroger/android-components that referenced this issue Jan 8, 2020
rocketsroger added a commit to rocketsroger/android-components that referenced this issue Jan 9, 2020
rocketsroger added a commit to rocketsroger/android-components that referenced this issue Jan 9, 2020
@liuche
Copy link
Contributor

liuche commented Jan 17, 2020

Happy to see you're working on this, @rocketsroger! could you give me an update on when we'd have this? I want to make sure we have enough time for Data Science to receive and process the data from here.

@rocketsroger
Copy link
Contributor

could you give me an update on when we'd have this?

Will do. The pr is up but there's another pr that might affect this one. I am waiting for the other pr to merge so I can continue working on this issue. I'll update. Thanks,

rocketsroger added a commit to rocketsroger/android-components that referenced this issue Jan 23, 2020
rocketsroger added a commit to rocketsroger/android-components that referenced this issue Jan 23, 2020
@rocketsroger rocketsroger added E5 Estimation points: 5 and removed E3 Estimation points: 3 labels Jan 23, 2020
rocketsroger added a commit to rocketsroger/android-components that referenced this issue Jan 24, 2020
rocketsroger added a commit to rocketsroger/android-components that referenced this issue Jan 24, 2020
bors bot pushed a commit that referenced this issue Jan 24, 2020
5700: Closes #5175: Add Glean keys for distinguishing between fatal and non-fatal native crashes r=Dexterp37,travis79 a=rocketsroger



Co-authored-by: Roger Yang <[email protected]>
bors bot pushed a commit that referenced this issue Jan 24, 2020
5700: Closes #5175: Add Glean keys for distinguishing between fatal and non-fatal native crashes r=Dexterp37,travis79 a=rocketsroger



Co-authored-by: Roger Yang <[email protected]>
@bors bors bot closed this as completed in a5ca943 Jan 24, 2020
@rocketsroger rocketsroger added this to the 29.0.0 milestone Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
<crash> Component: lib-crash E5 Estimation points: 5 🌟 feature New functionality and improvements
Projects
None yet
Development

No branches or pull requests

4 participants