Skip to content
This repository has been archived by the owner on Jan 12, 2023. It is now read-only.

Clicking notification item to delete history crashes the app #2499

Closed
nojunpark opened this issue Apr 21, 2018 · 1 comment
Closed

Clicking notification item to delete history crashes the app #2499

nojunpark opened this issue Apr 21, 2018 · 1 comment
Assignees
Labels

Comments

@nojunpark
Copy link

Steps to reproduce

Run systemBarHomeViewTest in TrashcanTest.java

  • Open website
  • Press home button to minimize the app
  • pull down the notification item, and tap the 'delete browsing history' text

Expected behavior

  • Opens Focus, history deleted
java.lang.NullPointerException: Attempt to invoke direct method 'void org.mozilla.focus.session.VisibilityLifeCycleCallback.finishAndRemoveTaskIfInBackground()' on a null object reference
at org.mozilla.focus.session.VisibilityLifeCycleCallback.finishAndRemoveTaskIfInBackground(VisibilityLifeCycleCallback.java:28)
at org.mozilla.focus.session.SessionNotificationService.onStartCommand(SessionNotificationService.java:70)
at android.app.ActivityThread.handleServiceArgs(ActivityThread.java:3474)
at android.app.ActivityThread.-wrap20(Unknown Source:0)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1692)
at android.os.Handler.dispatchMessage(Handler.java:106)
at android.os.Looper.loop(Looper.java:164)
at android.app.ActivityThread.main(ActivityThread.java:6494)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807)

Actual behavior

  • App crashes

Device information

Both on sim and device

@nojunpark nojunpark added the bug label Apr 21, 2018
ekager pushed a commit to ekager/focus-android that referenced this issue Apr 23, 2018
@ekager
Copy link
Contributor

ekager commented Apr 23, 2018

Found the problem and opened PR #2503

@ekager ekager self-assigned this Apr 23, 2018
@ekager ekager closed this as completed in 96c2b08 Apr 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants