Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug 1561697: add mozilla::ipc::WriteIPDLParam to prefix list #4973

Merged
merged 1 commit into from
Jun 28, 2019
Merged

bug 1561697: add mozilla::ipc::WriteIPDLParam to prefix list #4973

merged 1 commit into from
Jun 28, 2019

Conversation

willkg
Copy link
Contributor

@willkg willkg commented Jun 26, 2019

This adds mozilla::ipc::WriteIPDLParam to the prefix list so signature generation continues beyond it. By itself, it's too general a bucket. It'd help to know what the T actually is, but that breaks normalization. Continuing to the next frame should clarify the bucket.

This adds mozilla::ipc::WriteIPDLParam to the prefix list so signature
generation continues beyond it. By itself, it's too general a bucket.  It'd
help to know what the T actually is, but that breaks normalization.  Continuing
to the next frame should clarify the bucket.
@willkg
Copy link
Contributor Author

willkg commented Jun 26, 2019

Using the example crash report:

app@socorro:/app$ socorro-cmd signature 4fb422eb-61e3-425f-917c-2bb7f0190624
Crash id: 4fb422eb-61e3-425f-917c-2bb7f0190624
Original: mozilla::ipc::WriteIPDLParam<T>
New:      mozilla::ipc::WriteIPDLParam<T> | mozilla::dom::PContentParent::SendWindowPostMessage
Same?:    False

@willkg
Copy link
Contributor Author

willkg commented Jun 28, 2019

I'm pretty sure this is a step in the right direction. We can always do more later. self-r+

@willkg willkg merged commit e6412e7 into mozilla-services:master Jun 28, 2019
@willkg willkg deleted the 1561697-writeipdlparam branch July 2, 2019 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant