Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revising version of cryptography in requirements #1503

Closed
mreid-tt opened this issue Dec 5, 2023 · 0 comments
Closed

Revising version of cryptography in requirements #1503

mreid-tt opened this issue Dec 5, 2023 · 0 comments

Comments

@mreid-tt
Copy link

mreid-tt commented Dec 5, 2023

In your requirements.txt, cryptography is currently pinned to version 3.4.8:

# We pin cryptography to 3.4.8 due to a build error that occurs with the
# current version (36.0.0 at the time of this commit). In short, building
# the cryptography package with Rust results in a segfault, so we need to
# set the CRYPTOGRAPHY_DONT_BUILD_RUST env var to force the package to build
# with C instead. This env var is only present in cryptography<3.5.
cryptography==3.4.8

We have recently been updating the packaging of your Mozilla Sync Storage Rust application to support Synology devices. When building with OpenSSL 3, we encountered the following runtime error:

failed to create Tokenserver OAuth verifier: [..] undefined symbol: FIPS_mode

Investigating further, we found cryptography 3.4.8 is incompatible because FIPS_mode no longer exists in OpenSSL 3 per this issue: openssl/openssl#20266.

Upgrading to cryptography 41.0.3 in our packaging requirements resolved the problem. We suggest the team reevaluate if a newer cryptography version can now be used, as the original compilation issue may have been fixed in later releases. Leveraging newer versions can ensure compatibility with modern OpenSSL builds.

┆Issue is synchronized with this Jira Task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant