bug-1945509: switch from make to just #3116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This switches from make to just. While doing that, this also fixes a couple of other things: 1. fixes running the Django webapp using `manage.py runserver` when in a local dev environment; I think I broke this in 2023 when I switched the container to use Honcho to run the web and disk manager processes 2. removes the test-ci and frontend-ci services and instead uses docker-compose.override.yml to add volume mounts Tecken should work like other crash ingestion services now.
relud
approved these changes
Feb 3, 2025
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches from make to just. While doing that, this also fixes a couple of other things:
manage.py runserverwhen in a local dev environment; I think I broke this in 2023 when I switched the container to use Honcho to run the web and disk manager processesTecken should work like other crash ingestion services now.
While working through this, I pulled in
justfilerecipes from Socorro and Antenna. I fixed the volumes thing so it works the same way without thetest-ciandfrontend-cicontainers. I updated all the documentation. I looked through the repository for "make" and updated anything relevant. I updated CI actions to match Socorro.I went through and tested all the
justfilerecipes.I think I caught everything. However, since I made some fundamental changes to make Tecken match Socorro and Antenna, it's possible I missed something. We'll fix things as we move forward.