Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AutoSub to master #129

Merged
merged 1 commit into from
Apr 6, 2021
Merged

Add AutoSub to master #129

merged 1 commit into from
Apr 6, 2021

Conversation

abhirooptalasila
Copy link
Contributor

@abhirooptalasila abhirooptalasila commented Mar 28, 2021

As suggested.
@lissyx please review.

@lissyx
Copy link
Contributor

lissyx commented Apr 6, 2021

@abhirooptalasila It'd be awesome if you can add GitHub Actions test coverage for that on https://github.com/mozilla/DeepSpeech

@lissyx lissyx merged commit f422e31 into mozilla:master Apr 6, 2021
@abhirooptalasila
Copy link
Contributor Author

Thank you!
Can you also update README.rst to include AutoSub under Python subheading?

@abhirooptalasila
Copy link
Contributor Author

@abhirooptalasila It'd be awesome if you can add GitHub Actions test coverage for that on https://github.com/mozilla/DeepSpeech

I didn't get that. Can you elaborate?

@lissyx
Copy link
Contributor

lissyx commented Apr 6, 2021

Thank you!
Can you also update README.rst to include AutoSub under Python subheading?

Please PR it

@lissyx
Copy link
Contributor

lissyx commented Apr 6, 2021

@abhirooptalasila It'd be awesome if you can add GitHub Actions test coverage for that on https://github.com/mozilla/DeepSpeech

I didn't get that. Can you elaborate?

We had testing on TaskCluster for some examples, e.g., https://github.com/mozilla/DeepSpeech/blob/master/taskcluster/examples-vad_transcriber-py35.yml but we have now moved to GitHub Actions, we could use help and feedback as well as PR to implement examples testing back.

https://github.com/mozilla/DeepSpeech/projects/13
mozilla/DeepSpeech#3317

@abhirooptalasila
Copy link
Contributor Author

Thank you!
Can you also update README.rst to include AutoSub under Python subheading?

Please PR it

#130 and #131

@abhirooptalasila
Copy link
Contributor Author

@abhirooptalasila It'd be awesome if you can add GitHub Actions test coverage for that on https://github.com/mozilla/DeepSpeech

I didn't get that. Can you elaborate?

We had testing on TaskCluster for some examples, e.g., https://github.com/mozilla/DeepSpeech/blob/master/taskcluster/examples-vad_transcriber-py35.yml but we have now moved to GitHub Actions, we could use help and feedback as well as PR to implement examples testing back.

https://github.com/mozilla/DeepSpeech/projects/13
mozilla/DeepSpeech#3317

I haven't worked with GitHub Actions yet, but I'll have a look at update you soon 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants