Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split MZKeychainWrapper out of FxA Crate #4802

Closed
skhamis opened this issue Jan 31, 2022 · 1 comment
Closed

Split MZKeychainWrapper out of FxA Crate #4802

skhamis opened this issue Jan 31, 2022 · 1 comment

Comments

@skhamis
Copy link
Contributor

skhamis commented Jan 31, 2022

To get SPM working, we needed to bundle SwiftKeychainWrapper with FxA to get it working on iOS. This is really hacky and not an ideal situation.

Summary of problem: Since it’s a library we need as a depedency and so does FxiOS there ends up being two copies since SPM can’t correctly make the dep graph.

Potential solutions:

  1. Remove all SwiftKeychain files and put them in iOS
  • Since they are the only consumer, the consumer-specific files should be in iOS
  1. Create a script to split out SwiftKeychainWrapper in iOS during archiving

┆Issue is synchronized with this Jira Task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants