Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust/xcframework changes to allow firefox-ios to build using spm #4797

Merged
merged 4 commits into from
Jan 31, 2022

Conversation

skhamis
Copy link
Contributor

@skhamis skhamis commented Jan 26, 2022

This supports the work going on in mozilla-mobile/firefox-ios#9507 and is needed for allowing full SPM usage and removal of carthage.

Current Hack: SwiftKeychainWrapper had to be bundled with the XCFramework, I made a follow up task to eventually work on this: #4802

Pull Request checklist

  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGES_UNRELEASED.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them.

@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2022

Codecov Report

Merging #4797 (3cc74ae) into main (df53ad8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4797   +/-   ##
=======================================
  Coverage   81.53%   81.53%           
=======================================
  Files          49       49           
  Lines        5650     5650           
=======================================
  Hits         4607     4607           
  Misses       1043     1043           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df53ad8...3cc74ae. Read the comment docs.

@skhamis skhamis marked this pull request as ready for review January 31, 2022 19:50
@skhamis skhamis requested review from a team and tarikeshaq January 31, 2022 19:54
Copy link
Contributor

@tarikeshaq tarikeshaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I didn't review the MZKeyChainWrapper changes, I'm assuming those were just moved over

@skhamis skhamis merged commit 891d944 into mozilla:main Jan 31, 2022
@skhamis skhamis deleted the spm-changes branch January 31, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants