Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating XCode to v13.1.0 #4692

Merged
merged 3 commits into from
Dec 2, 2021
Merged

Conversation

nbhasin2
Copy link
Collaborator

@nbhasin2 nbhasin2 commented Dec 1, 2021

No description provided.

tarikeshaq
tarikeshaq previously approved these changes Dec 1, 2021
Copy link
Contributor

@tarikeshaq tarikeshaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you! As long as CI passes we can land this

@codecov-commenter
Copy link

Codecov Report

Merging #4692 (3007528) into main (d53cfa8) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4692      +/-   ##
==========================================
+ Coverage   80.52%   80.53%   +0.01%     
==========================================
  Files          48       48              
  Lines        5222     5220       -2     
==========================================
- Hits         4205     4204       -1     
+ Misses       1017     1016       -1     
Impacted Files Coverage Δ
components/nimbus/src/enrollment.rs 97.01% <0.00%> (-0.01%) ⬇️
components/nimbus/examples/experiment.rs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d53cfa8...3007528. Read the comment docs.

@mergify mergify bot dismissed tarikeshaq’s stale review December 2, 2021 00:06

The pull request has been modified, dismissing previous reviews.

@nbhasin2
Copy link
Collaborator Author

nbhasin2 commented Dec 2, 2021

Tested locally on phone and simulator. Everything looks good!!

Copy link
Contributor

@tarikeshaq tarikeshaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!! 🚀 🚀

@tarikeshaq tarikeshaq merged commit 664496e into mozilla:main Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants