Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nimbus SDK] Implement version targeting #4752

Merged
merged 7 commits into from
Dec 22, 2021
Merged

Conversation

tarikeshaq
Copy link
Contributor

fixes https://mozilla-hub.atlassian.net/browse/SDK-350

ports the desktop implementation of version comparison into the SDK

I still have a couple of todos in there, but otherwise, this should be in a good state. I wrote some docs in versioning.rs that will eventually be published on https://mozilla.github.io/application-services/book/rust-docs/nimbus/index.html

@travis79 feel free to modify this as you see fit - and let me know if there any more clarifications I can add to the brief docs I added (or if anything is confusing)

Pull Request checklist

  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGES_UNRELEASED.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them.

@tarikeshaq tarikeshaq requested a review from travis79 December 21, 2021 20:55
@tarikeshaq tarikeshaq changed the title Implement version targeting [Nimbus SDK] Implement version targeting Dec 21, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2021

Codecov Report

Merging #4752 (d944319) into main (4adb469) will increase coverage by 0.83%.
The diff coverage is 95.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4752      +/-   ##
==========================================
+ Coverage   80.53%   81.37%   +0.83%     
==========================================
  Files          48       49       +1     
  Lines        5220     5541     +321     
==========================================
+ Hits         4204     4509     +305     
- Misses       1016     1032      +16     
Impacted Files Coverage Δ
components/nimbus/src/error.rs 11.76% <0.00%> (-0.74%) ⬇️
components/nimbus/src/lib.rs 86.37% <ø> (ø)
components/nimbus/src/evaluator.rs 98.38% <93.84%> (-0.70%) ⬇️
components/nimbus/src/versioning.rs 96.12% <96.12%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4adb469...d944319. Read the comment docs.

Copy link
Member

@travis79 travis79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

components/nimbus/src/versioning.rs Show resolved Hide resolved
components/nimbus/src/versioning.rs Outdated Show resolved Hide resolved
@tarikeshaq tarikeshaq force-pushed the implement-version-targeting branch from d944319 to 0f6e041 Compare December 22, 2021 18:50
@tarikeshaq tarikeshaq force-pushed the implement-version-targeting branch from 0f6e041 to 1159bf3 Compare December 22, 2021 18:54
Copy link
Member

@travis79 travis79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! r+

@tarikeshaq tarikeshaq merged commit 4c0fa25 into main Dec 22, 2021
@tarikeshaq tarikeshaq deleted the implement-version-targeting branch December 22, 2021 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants