-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Nimbus SDK] Implement version targeting #4752
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4752 +/- ##
==========================================
+ Coverage 80.53% 81.37% +0.83%
==========================================
Files 48 49 +1
Lines 5220 5541 +321
==========================================
+ Hits 4204 4509 +305
- Misses 1016 1032 +16
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
d944319
to
0f6e041
Compare
0f6e041
to
1159bf3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! r+
fixes https://mozilla-hub.atlassian.net/browse/SDK-350
ports the desktop implementation of version comparison into the SDK
I still have a couple of todos in there, but otherwise, this should be in a good state. I wrote some docs in
versioning.rs
that will eventually be published on https://mozilla.github.io/application-services/book/rust-docs/nimbus/index.html@travis79 feel free to modify this as you see fit - and let me know if there any more clarifications I can add to the brief docs I added (or if anything is confusing)
Pull Request checklist
[ci full]
to the PR title.