Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow access to resource identifiers for drawables #4801

Merged
merged 4 commits into from
Jan 31, 2022

Conversation

jhugman
Copy link
Contributor

@jhugman jhugman commented Jan 31, 2022

This is No Bug followup for #4784 .

It allows access to the drawable resource identifier which is commonly used in Android app development.

It also has a small quality of life improvement for FML developers to generate code with a minimal set of imports.

Unneeded imports in the generated code is a large class of breaking changes.

This will minimize any breaking changes to only people already using Drawables (which I think is zero since it's a very new feature).

Pull Request checklist

  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGES_UNRELEASED.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them.

@jhugman jhugman requested a review from tarikeshaq January 31, 2022 11:41
Copy link
Contributor

@tarikeshaq tarikeshaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Like how the imports are not managed by the specific types!! 🚀 I'll land this so that we can ship it with the upcoming release

@tarikeshaq tarikeshaq merged commit 86242eb into main Jan 31, 2022
@tarikeshaq tarikeshaq deleted the jhugman/make-res-id-accessible-for-drawables branch January 31, 2022 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants