Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to opt-out from Nimbus rollouts #4807

Merged
merged 2 commits into from
Feb 3, 2022

Conversation

tarikeshaq
Copy link
Contributor

Fixes https://mozilla-hub.atlassian.net/browse/EXP-2156

Pull Request checklist

  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGES_UNRELEASED.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them.

@codecov-commenter
Copy link

Codecov Report

Merging #4807 (a269366) into main (2e88010) will decrease coverage by 0.00%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4807      +/-   ##
==========================================
- Coverage   81.49%   81.48%   -0.01%     
==========================================
  Files          49       49              
  Lines        5653     5656       +3     
==========================================
+ Hits         4607     4609       +2     
- Misses       1046     1047       +1     
Impacted Files Coverage Δ
components/nimbus/src/enrollment.rs 96.96% <80.00%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e88010...a269366. Read the comment docs.

@jhugman
Copy link
Contributor

jhugman commented Feb 2, 2022

Is this what we want? ISTR we decided we didn't want to opt out of rollouts (just experiments/studies).

@tarikeshaq
Copy link
Contributor Author

Is this what we want? ISTR we decided we didn't want to opt out of rollouts (just experiments/studies).

@jhugman yeah, confirmed on slack with Jared when the bug was filed

Copy link
Contributor

@jhugman jhugman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants