Add is_remote flag to HistoryVisitInfo #4810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops - meant to say I used |
Codecov Report
@@ Coverage Diff @@
## main #4810 +/- ##
=======================================
Coverage 81.49% 81.49%
=======================================
Files 49 49
Lines 5653 5653
=======================================
Hits 4607 4607
Misses 1046 1046 Continue to review full report at Codecov.
|
|
Thanks, @mhammond ! |
grigoryk
approved these changes
Feb 1, 2022
| @@ -278,6 +278,7 @@ dictionary HistoryVisitInfo { | |||
| VisitTransition visit_type; | |||
| boolean is_hidden; | |||
| Url? preview_image_url; | |||
| boolean is_remote; | |||
mhammond
added a commit
to mhammond/application-services
that referenced
this pull request
Feb 1, 2022
mhammond
added a commit
to mhammond/application-services
that referenced
this pull request
Feb 1, 2022
mhammond
added a commit
to mhammond/application-services
that referenced
this pull request
Feb 1, 2022
mhammond
added a commit
to mhammond/application-services
that referenced
this pull request
Feb 1, 2022
bendk
pushed a commit
that referenced
this pull request
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this all we need? CC @mavduevskiy
Fixes #4779.