Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creates deterministic ordering of features for experimenter manifest #4819

Merged
merged 3 commits into from
Feb 10, 2022

Conversation

tarikeshaq
Copy link
Contributor

fixes https://mozilla-hub.atlassian.net/browse/EXP-2184

Pull Request checklist

  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGES_UNRELEASED.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them.

@tarikeshaq tarikeshaq requested a review from jhugman February 3, 2022 15:02
@tarikeshaq tarikeshaq force-pushed the fix-ordering-experimenter-manifest branch from 7b51d49 to 1a8855c Compare February 7, 2022 21:42
@tarikeshaq tarikeshaq force-pushed the fix-ordering-experimenter-manifest branch from 1a8855c to 427bf23 Compare February 7, 2022 21:42
@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2022

Codecov Report

Merging #4819 (87a16c4) into main (3151f8c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4819   +/-   ##
=======================================
  Coverage   81.51%   81.51%           
=======================================
  Files          56       56           
  Lines        5663     5663           
=======================================
  Hits         4616     4616           
  Misses       1047     1047           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3151f8c...87a16c4. Read the comment docs.

Copy link

@eliserichards eliserichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🎉 :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants