Add stringHelper to NimbusMessageHelper. #4831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4831 +/- ##
==========================================
- Coverage 81.51% 81.28% -0.24%
==========================================
Files 57 58 +1
Lines 5665 5743 +78
==========================================
+ Hits 4618 4668 +50
- Misses 1047 1075 +28
Continue to review full report at Codecov.
|
jhugman
requested review from
tarikeshaq and
travis79
and removed request for
tarikeshaq
tarikeshaq
reviewed
Feb 10, 2022
jhugman
commented
Feb 11, 2022
| ) -> Result<Arc<NimbusStringHelper>> { | ||
| let context = self.merge_additional_context(additional_context)?; | ||
| let helper = NimbusStringHelper::new(context.as_object().unwrap().to_owned()); | ||
| Ok(Arc::new(helper)) |
There was a problem hiding this comment.
Deliberately trying to keep string helper and targeting helper separate, because I don't know how the Glean targeting helper is going to play out.
jhugman
force-pushed
the
jhugman/exp-2159-add-string-template-to-message-helper
branch
from
15b527f to
f96203a
Compare
jhugman
deleted the
jhugman/exp-2159-add-string-template-to-message-helper
branch
This was referenced Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes EXP-2159.
This PR adds a string interpolation method to the MessageHelper.
This might better be done in Kotlin and Swift, but there is some fiddly logic which needs to be the same in both places, so we did it in Rust.
The fiddly logic was:
Pull Request checklist
[ci full]to the PR title.