Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static start time and clear events #5279

Merged
merged 11 commits into from
Dec 7, 2022

Conversation

jeddai
Copy link
Member

@jeddai jeddai commented Dec 7, 2022

  • Adds methods in Kotlin/Swift to clear the event store
  • Adds Swift methods to wait for operation queues to finish
  • Updates event store to default its starting time to the beginning of the year

https://mozilla-hub.atlassian.net/browse/EXP-2965
https://mozilla-hub.atlassian.net/browse/EXP-2957

Pull Request checklist

  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGES_UNRELEASED.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them.

Branch builds: add [ff-android: firefox-android-branch-name] and/or [fenix: fenix-branch-name] to the PR title.

@codecov-commenter
Copy link

Codecov Report

Base: 46.15% // Head: 46.27% // Increases project coverage by +0.12% 🎉

Coverage data is based on head (710bf4e) compared to base (4525f96).
Patch coverage: 86.48% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5279      +/-   ##
==========================================
+ Coverage   46.15%   46.27%   +0.12%     
==========================================
  Files         178      178              
  Lines       14274    14320      +46     
==========================================
+ Hits         6588     6627      +39     
- Misses       7686     7693       +7     
Impacted Files Coverage Δ
components/nimbus/src/lib.rs 68.45% <0.00%> (-0.78%) ⬇️
components/nimbus/src/behavior.rs 87.72% <61.53%> (-0.43%) ⬇️
components/nimbus/src/tests/test_behavior.rs 98.07% <100.00%> (+0.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@travis79 travis79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to block on, just a couple of comments

components/nimbus/src/behavior.rs Show resolved Hide resolved
components/nimbus/src/tests/test_behavior.rs Outdated Show resolved Hide resolved
@jeddai jeddai merged commit 037c913 into mozilla:main Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants