Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breakage reading old version of tabs from database (#5284) #5286

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

mhammond
Copy link
Member

@mhammond mhammond commented Dec 8, 2022

No description provided.

@mhammond mhammond requested a review from skhamis December 8, 2022 23:35
@mhammond mhammond force-pushed the fix-old-tab-versions branch from 05de0ce to c2ec694 Compare December 8, 2022 23:45
@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2022

Codecov Report

Base: 46.29% // Head: 46.29% // No change to project coverage 👍

Coverage data is based on head (db16910) compared to base (6ef3a2f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5286   +/-   ##
=======================================
  Coverage   46.29%   46.29%           
=======================================
  Files         180      180           
  Lines       14340    14340           
=======================================
  Hits         6638     6638           
  Misses       7702     7702           
Impacted Files Coverage Δ
components/tabs/src/storage.rs 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@skhamis skhamis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test. Looks like the right thing for anyone that still has the old payload -- 🚢

@mhammond mhammond force-pushed the fix-old-tab-versions branch from c2ec694 to db16910 Compare December 8, 2022 23:55
@mhammond mhammond merged commit a2f862e into mozilla:main Dec 9, 2022
@mhammond mhammond deleted the fix-old-tab-versions branch December 9, 2022 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants