Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isVisible() does not trim "visible" elements that are hidden with extreme xy coords #232

Open
danielhertenstein opened this issue Mar 31, 2020 · 0 comments
Labels
javascript Requires work in primarily the JS language

Comments

@danielhertenstein
Copy link
Collaborator

If a sample (see mozilla-services/fathom-login-forms@f00fbcf5 for samples that were manually edited because of this) has an element that is hidden by using extreme xy coordinates (the linked examples has an element at x = -10000) but is otherwise visible according to the logic in our isVisible() function, that samples can slip through the vectorizer when it is considering only visible elements for a DOM selector or rule. We need to find a way to address these elements.

Elements that have negative xy coordinates could be filtered using element.x + element.width + element.ownerDocument.defaultView.scrollX < 0, but this can also filter out elements that are not frozen as expected (see #231).

@danielhertenstein danielhertenstein added the javascript Requires work in primarily the JS language label Mar 31, 2020
erikrose added a commit that referenced this issue Apr 30, 2020
…ther horizontally or vertically.

Relevant to #232 ever so slightly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Requires work in primarily the JS language
Projects
None yet
Development

No branches or pull requests

1 participant