Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing #113

Closed
edward-hong opened this issue Oct 13, 2020 · 2 comments
Closed

Testing #113

edward-hong opened this issue Oct 13, 2020 · 2 comments

Comments

@edward-hong
Copy link

Currently there's only an example test. It would be a good idea to add some testing maybe with something like svelte-testing-library along with Jest. This way we can familiarise ourselves with the codebase through writing some tests.

@wlach
Copy link
Contributor

wlach commented Oct 14, 2020

Hi @edward-hong, this is a good idea though the application doesn't have a lot of business logic at the moment so there's not a ton to test. I think running storybook snapshot tests might be a better approach at this point, see #117

Let's keep this open though and return to it later. I'm sure we'll start accumulating stuff to test before too long...

@wlach
Copy link
Contributor

wlach commented Dec 16, 2020

We now have one test:

https://github.com/mozilla/glean-dictionary/blob/main/tests/state.urls.test.js

I'm sure we'll add more as time goes on. Closing this one.

@wlach wlach closed this as completed Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants