Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run storybook tests in ci #117

Closed
wlach opened this issue Oct 14, 2020 · 5 comments · Fixed by #194
Closed

Run storybook tests in ci #117

wlach opened this issue Oct 14, 2020 · 5 comments · Fixed by #194
Assignees

Comments

@wlach
Copy link
Contributor

wlach commented Oct 14, 2020

Storybook snapshot tests in CI (where we verify that stories still render after a pull request) can often catch problems, e.g. it was helpful in the iodide project (see iodide-project/iodide#2506). I'm not sure how to set this up in Svelte but I'm guessing it should be possible. You can see the aforementioned PR for iodide for some ideas.

@wlach
Copy link
Contributor Author

wlach commented Oct 14, 2020

@edward-hong care to give this a try?

@edward-hong
Copy link

Yea sure I'll take a crack at this

@DawoodShahat
Copy link
Contributor

@wlach Can I work on this issue?

@wlach wlach assigned DawoodShahat and unassigned edward-hong Nov 11, 2020
@wlach
Copy link
Contributor Author

wlach commented Nov 11, 2020

@wlach Can I work on this issue?

I think so, it's been nearly a month so am guessing Edward has moved on. This would be hugely valuable BTW (it would give us enough confidence to auto-merge dependabot PRs, which is currently a manual process)

@DawoodShahat
Copy link
Contributor

Yeah thanks, will start working on it right away.

@DawoodShahat DawoodShahat mentioned this issue Nov 14, 2020
3 tasks
wlach added a commit that referenced this issue Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants