-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run storybook tests in ci #117
Labels
Comments
@edward-hong care to give this a try? |
Closed
Yea sure I'll take a crack at this |
@wlach Can I work on this issue? |
I think so, it's been nearly a month so am guessing Edward has moved on. This would be hugely valuable BTW (it would give us enough confidence to auto-merge dependabot PRs, which is currently a manual process) |
Yeah thanks, will start working on it right away. |
wlach
added a commit
that referenced
this issue
Nov 20, 2020
Co-authored-by: William Lachance <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Storybook snapshot tests in CI (where we verify that stories still render after a pull request) can often catch problems, e.g. it was helpful in the iodide project (see iodide-project/iodide#2506). I'm not sure how to set this up in Svelte but I'm guessing it should be possible. You can see the aforementioned PR for iodide for some ideas.
The text was updated successfully, but these errors were encountered: