Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1648422 - Add events to the C# language bindings #1129

Merged
merged 4 commits into from
Aug 5, 2020

Conversation

Dexterp37
Copy link
Contributor

This follows the Kotlin implementation, adds tests and user docs.

@auto-assign auto-assign bot requested a review from mdboom August 5, 2020 09:37
@Dexterp37 Dexterp37 requested review from brizental and removed request for mdboom August 5, 2020 09:38
@Dexterp37 Dexterp37 changed the title Add events to the C# language bindings Bug 1648422 - Add events to the C# language bindings Aug 5, 2020
Copy link
Contributor

@brizental brizental left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, r+wc

glean-core/csharp/Glean/Metrics/EventMetricType.cs Outdated Show resolved Hide resolved
glean-core/csharp/Glean/Metrics/EventMetricType.cs Outdated Show resolved Hide resolved
@Dexterp37 Dexterp37 merged commit 96c8f36 into mozilla:main Aug 5, 2020
@Dexterp37 Dexterp37 deleted the csharp_events branch August 5, 2020 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants