Bug 1676866 - Migrate to safe mode #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dexterp37
reviewed
Nov 13, 2020
Dexterp37
reviewed
Nov 16, 2020
[doc only] Co-authored-by: Alessio Placitelli <[email protected]>
Dexterp37
approved these changes
Nov 16, 2020
[doc only]
badboy
force-pushed
the
migrate-to-safe-mode
branch
from
db70a96 to
abdb786
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This automatically migrates an existing LMDB database of Glean to a safe-mode database, if and only if the
rkv-safe-modefeature is activated on the glean-core crate.The plan will be to enable this in mozilla-central.
I already took this for a manual test using my local m-c checkout and migration succeeds as expected and keeps the
client_info.client_id.