Bug 1680789 - Properly shut down glean in tests (RLB) #1375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code in this PR is currently being tested in FOG CI. The BR jobs should not fail due to Glean problems :) Unfortunately, they can't be retriggered in a simple way, so Aryx is doing us the gigantic favour of triggering them manually. Moreover, they can't run in parallel, so Aryx will trigger them throughout his day. One by one. |
badboy
approved these changes
Dec 9, 2020
|
All right, this indeed seems to fix the FOG problems! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FOG tests sometimes don't do anything other than initializing Glean. In these cases, nothing blocks on the dispatcher and tests might end up triggering init twice, in parallel, locking files on the disk or corrupting local data. This, in turn, makes FOG tests flaky and even RLB tests occasionally fail.