Bug 1677451 - Implement Memory Distribution in the RLB #1376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chutten
force-pushed
the
bug1677451-memdistRLB
branch
5 times, most recently
from
5119f94 to
f7c41b2
Compare
|
RFAL |
mdboom
approved these changes
Dec 9, 2020
| ``` | ||
|
|
||
| </div> | ||
|
|
There was a problem hiding this comment.
Also add a link to the Rust API docs in the "Reference" section below.
chutten
force-pushed
the
bug1677451-memdistRLB
branch
from
f7c41b2 to
5dc3b96
Compare
Dexterp37
approved these changes
Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, while I was here I added
test_get_num_recorded_errorsbecause any metric that records errors should expose this method (heck, maybe all metrics should expose this method for consistency's sake)