Bug 1685522 - Add the 'clients activity API' and implement the baseline ping for the RLB #1455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dexterp37
force-pushed
the
activity_api
branch
from
b71d05d to
4bc764b
Compare
badboy
requested changes
Jan 26, 2021
There was a problem hiding this comment.
Implementation-wise this looks good.
Few things I'd like some rephrasing on.
One thing I realized is that we don't really have docs on how to integrate the RLB, that is: when to call what function.
It doesn't need to be solved in this PR (except maybe a short call out where/when handle_(in)active needs to happen)
glean-core/android/src/main/java/mozilla/telemetry/glean/Glean.kt
Outdated
Show resolved
Hide resolved
This makes the naming scheme a bit more meaningful outside of the mobile space. This additionally updates the documentation.
This additionally updates the docs.
Dexterp37
force-pushed
the
activity_api
branch
from
f0ae668 to
c87022c
Compare
badboy
requested changes
Jan 27, 2021
badboy
requested changes
Jan 27, 2021
This additionally ports the tests from the Kotlin implementation.
This checks if the dirty bit is set at startup and generates the relative ping. It additionally ports the relevant tests from Kotlin.
This additionally moves the logic from the GleanLifecycleObserver to the Glean.kt file. The logic was spread between the two files, making it harder than needed to understand what happened when changing the state. This additionally fixes the tests.
Dexterp37
force-pushed
the
activity_api
branch
from
d6beb33 to
86a3eab
Compare
badboy
approved these changes
Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a bunch of things:
baselineping with reasondirty_startupfor the RLB;TODO:
Swift!(filed a bug)