Bug 1691953 - Android: Remove support for reading app version info from package manager #1752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badboy
force-pushed
the
buildinfo-required
branch
2 times, most recently
from
4a5e46c to
2da5083
Compare
Dexterp37
approved these changes
Aug 17, 2021
…ager This removes the previously deprecated functionatilty. Passing in the build-time generated `BuildInfo` struct is required.
badboy
force-pushed
the
buildinfo-required
branch
from
2da5083 to
7d495c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the previously deprecated functionatilty.
Passing in the build-time generated
BuildInfostruct is required.I'll wait with landing this until I have the geckoview work done, so that this can go in a later major release as needed (because technicall a breaking change)