Bug 1727760 - Implement the Url type #1778
Conversation
| Self { meta } | ||
| } | ||
|
|
||
| fn is_valid_url_scheme(&self, value: String) -> bool { |
There was a problem hiding this comment.
Maybe include a link to the url scheme spec, which explains that -, + and . are allowed.
Filed right now :) https://bugzilla.mozilla.org/show_bug.cgi?id=1729030 I also rebased on the latest main to see if it fixes the tests :) |
glean-core/android/src/main/java/mozilla/telemetry/glean/private/UrlMetricType.kt
Outdated
Show resolved
Hide resolved
glean-core/android/src/main/java/mozilla/telemetry/glean/private/UrlMetricType.kt
Outdated
Show resolved
Hide resolved
| /* This file is based on the tests in the Glean android-components implementation. | ||
| * | ||
| * Care should be taken to not reorder elements in this file so it will be easier | ||
| * to track changes in Glean android-components. | ||
| */ |
glean-core/src/metrics/mod.rs
Outdated
| @@ -121,6 +123,8 @@ pub enum Metric { | |||
| Jwe(String), | |||
| /// A rate metric. See [`RateMetric`] for more information. | |||
| Rate(i32, i32), | |||
| /// TODO | |||
There was a problem hiding this comment.
Still TODO? (I also am curious why this isn't in alphabetic order, but since it has been that way for some time... meh)
There was a problem hiding this comment.
Sadly this can't be in alphabetical order, because the order of these enum items matter when serializing/deserializing. If we change the order we might end up breaking loading up old data files. See line 88.
There was a problem hiding this comment.
Gotcha, makes sense. When reviewing this through the GitHub UI, it had masked line 88 so I didn't see that.
glean-core/android/src/test/java/mozilla/telemetry/glean/private/UrlMetricTypeTest.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Travis Long <[email protected]>
No description provided.