Support Python 3.10 #1818
Merged
Support Python 3.10 #1818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also uses the "next gen" Python Docker images from CircleCI. Also removes some `persist_to_workspace` that is no longer needed.
mdboom
commented
Oct 6, 2021
| @@ -82,7 +82,7 @@ commands: | |||
| - run: | |||
| name: Setup custom environment variables | |||
| command: | | |||
| echo "export PATH=$HOME/.cargo/bin:$PATH" >> $BASH_ENV | |||
| echo 'export PATH=$HOME/.cargo/bin:$PATH' >> $BASH_ENV | |||
There was a problem hiding this comment.
See this support page for why this is necessary.
Dexterp37
approved these changes
Oct 7, 2021
.circleci/config.yml
Outdated
| @@ -858,6 +860,7 @@ jobs: | |||
|
|
|||
| Python Windows i686 tests: | |||
| docker: | |||
| # Windows tests require "legacy" Docker images | |||
There was a problem hiding this comment.
I don't know why this is, but I would guess some kind of difference in the mingw compiler, causing one of the tests to fail. Good point that I should probably file a new bug to address this later (I don't think it's a high enough priority to do this now).
There was a problem hiding this comment.
I actually figured it out. \o/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also uses the "next gen" Python Docker images from CircleCI.
Also removes some
persist_to_workspacethat is no longer needed.