-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added test for zh_TW locale #10
base: master
Are you sure you want to change the base?
Conversation
r+? |
@rbillings Hmm, I'm not sure why this is in the |
@stephendonner - is there a reason why #5 is in this repo? |
@stephendonner ping |
Sorry I missed the earlier ping.
Here's the actual locale test that issue #5 was hoping to agument: https://github.com/mozilla/marketing-project-template/blob/master/tests/test_file.py#L32 |
@@ -45,6 +45,18 @@ def test_locale(self, mozwebqa): | |||
print "There is no language selector on the page" | |||
|
|||
@pytest.mark.nondestructive | |||
def test_locale_zh_TW (self, mozwebqa): | |||
main_page = MySiteHomePage(mozwebqa) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should include a docstring to explain the test here. If I understand correctly we want to check that opening [base]/zh_TW should either stay as [base]/zh_TW or become [base]/en-US. If this is the case I would attempt to make this test a little more generic using a list of locales that this could apply to (with just one for now). I would therefore also update the name of the test to reflect this. Something like test_locales_persist_or_fallback_to_en_us
.
I think @bobsilverberg was confusing this with the https://github.com/mozilla/mozwebqa-test-templates repository. Even though this suite is not currently being run (since the Jenkins migration) the issue/test seems valid to me. |
I'm just reviewing all open PRs and found this one. I must admit I'm still a bit confused about it, and yes, I guess I was confusing this repo with https://github.com/mozilla/mozwebqa-test-templates. In any case, there have been a bunch of comments made my @davehunt that are waiting to be addressed. @rbillings are you going to continue with this PR and attempt to address @davehunt's comments? |
I will complete this- it's just low on the totem pole. I'll aim for early June as I doubt I'll get to it this week. |
I updated this, but am unsure how to run the test to verify that it would actually work. |
@@ -9,6 +9,7 @@ | |||
|
|||
from pages.page_object import MySiteHomePage | |||
from unittestzero import Assert | |||
from urlparse import urljoin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Standard library imports should be at the top. See http://legacy.python.org/dev/peps/pep-0008/#imports
FIx for issue #5