Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #21, add build step for mozilla-central #26

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Conversation

dmose
Copy link
Member

@dmose dmose commented Jul 7, 2022

This adds a build step and creates an artifact for use as a JSM in mozilla-central.

This uses pretty much exactly the code from Normandy (including the same ancient versions of the dependencies). That's clearly worth fixing, and probably wants a spin-off ticket from this one, but the point of this ticket is really just to be able to build something from source that's similar enough to the current thing. Migrating a couple of major versions of webpack can happen in another ticket.

This ticket also stops pre-minifying the artifact, as it's going to be compressed in the omnijar in Firefox anyway, and removes unneeded dependencies.

To test:

$ yarn install 
$ yarn test
$ yarn build
$ cp vendor/mozjexl.js ../mozilla-central/toolkit/components/utils/
$ cd !$
$ ./mach build
$ ./mach test toolkit/components/messaging-system/targeting/test/unit

@dmose
Copy link
Member Author

dmose commented Jul 7, 2022

Still need to add a bit of documentation and steps for testing.

@dmose dmose requested a review from freshstrangemusic July 11, 2022 16:32
@dmose dmose self-assigned this Jul 11, 2022
@dmose
Copy link
Member Author

dmose commented Jul 11, 2022

@brennie, I'd love a review so that it's possible to build stuff for m-c again. There are lots of things that could be fixed here; I feel like this is the right first step.

Copy link
Member

@freshstrangemusic freshstrangemusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ with some minor nits

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
webpack.config.js Outdated Show resolved Hide resolved
webpack.config.js Outdated Show resolved Hide resolved
@dmose dmose merged commit 2f6cc44 into mozilla:master Jul 11, 2022
@dmose dmose deleted the buildit branch July 11, 2022 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants