Add mode to throw on invalid prop access, fixes #25 #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that the fix for #21 will want to land before this one, at which time I'll rebase this PR. (This has been done). |
dmose
force-pushed
the
error-handling
branch
4 times, most recently
from
e88d7b4 to
cd8ea07
Compare
dmose
changed the title
dmose
force-pushed
the
error-handling
branch
4 times, most recently
from
36a21ef to
93db993
Compare
brennie
reviewed
Oct 7, 2022
brennie
requested changes
Oct 7, 2022
brennie
approved these changes
Nov 11, 2022
Comment on lines
+17
to
+20
| var lexer = new Lexer(grammar); | ||
|
|
||
| function toTree(exp) { | ||
| var p = new Parser(grammar); |
| return e.eval(toTree("(2 + 3) * 4")).should.become(20); | ||
| }); | ||
| it("should evaluate a string concat", function() { | ||
| var e = new Evaluator(grammar, null, null, null, true); |
| @@ -107,7 +110,7 @@ describe("Evaluator", function() { | |||
| }); | |||
| it("should throw when transform does not exist", function() { | |||
| var e = new Evaluator(grammar); | |||
| return e.eval(toTree('"hello"|world')).should.reject; | |||
| return e.eval(toTree('"hello"|world')).should.be.rejected; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add mode to throw on invalid property access. In the default mode, everything should stay the same. In the new mode, there are various semantic changes, so we'll need to roll this out to Firefox with care.
Note that this branch is based on https://github.com/mozilla/mozjexl/pull/31/files so that we can actually see whether anything got broken in CI.