Skip to content

Commit

Permalink
Replaces literal {} created lookup tables with Object.create
Browse files Browse the repository at this point in the history
  • Loading branch information
yurydelendik committed Jan 28, 2016
1 parent d6adf84 commit 2edf279
Show file tree
Hide file tree
Showing 18 changed files with 106 additions and 104 deletions.
10 changes: 5 additions & 5 deletions src/core/chunked_stream.js
Original file line number Diff line number Diff line change
Expand Up @@ -313,9 +313,9 @@ var ChunkedStreamManager = (function ChunkedStreamManagerClosure() {

this.currRequestId = 0;

this.chunksNeededByRequest = {};
this.requestsByChunk = {};
this.promisesByRequest = {};
this.chunksNeededByRequest = Object.create(null);
this.requestsByChunk = Object.create(null);
this.promisesByRequest = Object.create(null);
this.progressiveDataLength = 0;

this._loadedStreamCapability = createPromiseCapability();
Expand All @@ -341,9 +341,9 @@ var ChunkedStreamManager = (function ChunkedStreamManagerClosure() {
_requestChunks: function ChunkedStreamManager_requestChunks(chunks) {
var requestId = this.currRequestId++;

var chunksNeeded;
var i, ii;
this.chunksNeededByRequest[requestId] = chunksNeeded = {};
var chunksNeeded = Object.create(null);
this.chunksNeededByRequest[requestId] = chunksNeeded;
for (i = 0, ii = chunks.length; i < ii; i++) {
if (!this.stream.hasChunk(chunks[i])) {
chunksNeeded[chunks[i]] = true;
Expand Down
10 changes: 5 additions & 5 deletions src/core/evaluator.js
Original file line number Diff line number Diff line change
Expand Up @@ -731,7 +731,7 @@ var PartialEvaluator = (function PartialEvaluatorClosure() {

var self = this;
var xref = this.xref;
var imageCache = {};
var imageCache = Object.create(null);

assert(operatorList);

Expand Down Expand Up @@ -1054,7 +1054,7 @@ var PartialEvaluator = (function PartialEvaluatorClosure() {

// The xobj is parsed iff it's needed, e.g. if there is a `DO` cmd.
var xobjs = null;
var xobjsCache = {};
var xobjsCache = Object.create(null);

var preprocessor = new EvaluatorPreprocessor(stream, xref, stateManager);

Expand Down Expand Up @@ -2093,7 +2093,7 @@ var TranslatedFont = (function TranslatedFontClosure() {
var charProcs = this.dict.get('CharProcs').getAll();
var fontResources = this.dict.get('Resources') || resources;
var charProcKeys = Object.keys(charProcs);
var charProcOperatorList = {};
var charProcOperatorList = Object.create(null);
for (var i = 0, n = charProcKeys.length; i < n; ++i) {
loadCharProcsPromise = loadCharProcsPromise.then(function (key) {
var glyphStream = charProcs[key];
Expand Down Expand Up @@ -2147,7 +2147,7 @@ var OperatorList = (function OperatorListClosure() {
this.messageHandler = messageHandler;
this.fnArray = [];
this.argsArray = [];
this.dependencies = {};
this.dependencies = Object.create(null);
this._totalLength = 0;
this.pageIndex = pageIndex;
this.intent = intent;
Expand Down Expand Up @@ -2227,7 +2227,7 @@ var OperatorList = (function OperatorListClosure() {
pageIndex: this.pageIndex,
intent: this.intent
}, transfers);
this.dependencies = {};
this.dependencies = Object.create(null);
this.fnArray.length = 0;
this.argsArray.length = 0;
}
Expand Down
2 changes: 1 addition & 1 deletion src/core/font_renderer.js
Original file line number Diff line number Diff line change
Expand Up @@ -609,7 +609,7 @@ var FontRendererFactory = (function FontRendererFactoryClosure() {
var noop = '';

function CompiledFont(fontMatrix) {
this.compiledGlyphs = {};
this.compiledGlyphs = Object.create(null);
this.fontMatrix = fontMatrix;
}
CompiledFont.prototype = {
Expand Down
Loading

0 comments on commit 2edf279

Please sign in to comment.