Don't reset temporary XRef-entries during saving (PR 16392 follow-up)

*Please note:* I'm not aware of any bugs caused by this, however that might be more luck than anything else. In PR 16392 the `incrementalUpdate` function, and all of its various helpers, were made asynchronous. However the call-site in `src/core/worker.js` wasn't updated, which means that we currently reset temporary XRef-entries while saving is currently ongoing.
mozilla · Jul 20, 2023 · 51fd79c · 51fd79c
1 parent 0702663
commit 51fd79c
Showing 1 changed file with 14 additions and 16 deletions.
diff --git a/src/core/worker.js b/src/core/worker.js
@@ -661,23 +661,21 @@ class WorkerMessageHandler {
             };
           }
 
-          try {
-            return incrementalUpdate({
-              originalData: stream.bytes,
-              xrefInfo: newXrefInfo,
-              newRefs,
-              xref,
-              hasXfa: !!xfa,
-              xfaDatasetsRef,
-              hasXfaDatasetsEntry,
-              needAppearances,
-              acroFormRef,
-              acroForm,
-              xfaData,
-            });
-          } finally {
+          return incrementalUpdate({
+            originalData: stream.bytes,
+            xrefInfo: newXrefInfo,
+            newRefs,
+            xref,
+            hasXfa: !!xfa,
+            xfaDatasetsRef,
+            hasXfaDatasetsEntry,
+            needAppearances,
+            acroFormRef,
+            acroForm,
+            xfaData,
+          }).finally(() => {
             xref.resetNewTemporaryRef();
-          }
+          });
         });
       }
     );