Merge pull request #17940 from timvandermeij/scripting-test

Fix the "must check that invisible fields are made visible" scripting integration test
mozilla · Apr 15, 2024 · 60f02ea · 60f02ea
2 parents e08de77 + 2e9bd49
commit 60f02ea
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/test/integration/scripting_spec.mjs b/test/integration/scripting_spec.mjs
@@ -2104,9 +2104,10 @@ describe("Interaction", () => {
           expect(visibility).withContext(`In ${browserName}`).toEqual("hidden");
 
           await page.click(getSelector("11R"));
-          // eslint-disable-next-line no-restricted-syntax
-          await waitForTimeout(10);
 
+          await page.waitForFunction(
+            `${getComputedStyleSelector("7R")}.visibility !== "hidden"`
+          );
           visibility = await page.$eval(
             getSelector("7R"),
             el => getComputedStyle(el).visibility
@@ -2115,6 +2116,9 @@ describe("Interaction", () => {
             .withContext(`In ${browserName}`)
             .toEqual("visible");
 
+          await page.waitForFunction(
+            `${getComputedStyleSelector("8R")}.visibility !== "hidden"`
+          );
           visibility = await page.$eval(
             getSelector("8R"),
             el => getComputedStyle(el).visibility