Add a pref to know if the alt-text must be automatically generated (b…

…ug 1909310)
mozilla · Jul 22, 2024 · c4594a1 · c4594a1
1 parent 91655aa
commit c4594a1
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 4 deletions.
diff --git a/extensions/chromium/preferences_schema.json b/extensions/chromium/preferences_schema.json
@@ -55,6 +55,10 @@
       "type": "boolean",
       "default": false
     },
+    "enableGuessAltText": {
+      "type": "boolean",
+      "default": true
+    },
     "altTextLearnMoreUrl": {
       "type": "string",
       "default": ""

diff --git a/web/app.js b/web/app.js
@@ -205,10 +205,10 @@ const PDFViewerApplication = {
       if (mode) {
         document.documentElement.classList.add(mode);
       }
-    } else {
+    } else if (AppOptions.get("enableAltText")) {
       // We want to load the image-to-text AI engine as soon as possible.
       this.mlManager = new MLManager({
-        enableAltText: AppOptions.get("enableAltText"),
+        enableGuessAltText: AppOptions.get("enableGuessAltText"),
         altTextLearnMoreUrl: AppOptions.get("altTextLearnMoreUrl"),
       });
     }

diff --git a/web/app_options.js b/web/app_options.js
@@ -179,6 +179,11 @@ const defaultOptions = {
     value: false,
     kind: OptionKind.VIEWER + OptionKind.PREFERENCE,
   },
+  enableGuessAltText: {
+    /** @type {boolean} */
+    value: true,
+    kind: OptionKind.VIEWER + OptionKind.PREFERENCE,
+  },
   enableHighlightEditor: {
     // We'll probably want to make some experiments before enabling this
     // in Firefox release, but it has to be temporary.

diff --git a/web/firefoxcom.js b/web/firefoxcom.js
@@ -328,8 +328,8 @@ class MLManager {
     return FirefoxCom.requestAsync("mlGuess", data);
   }
 
-  enable({ altTextLearnMoreUrl, enableAltText, listenToProgress }) {
-    if (enableAltText) {
+  enable({ altTextLearnMoreUrl, enableGuessAltText, listenToProgress }) {
+    if (enableGuessAltText) {
       this.#loadAltTextEngine(listenToProgress);
     }
     // The `altTextLearnMoreUrl` is used to provide a link to the user to learn