[Editor] Avoid to have the ML disclaimer when the ML engine isn't rea…

…dy (bug 1917543)
mozilla · Sep 9, 2024 · f8b3a85 · f8b3a85
1 parent a1b45d6
commit f8b3a85
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 2 deletions.
diff --git a/test/integration/stamp_editor_spec.mjs b/test/integration/stamp_editor_spec.mjs
@@ -1096,5 +1096,28 @@ describe("Stamp Editor", () => {
         await page.waitForSelector("#newAltTextDialog", { visible: false });
       }
     });
+
+    it("must check the new alt text flow (part 3)", async () => {
+      // Run sequentially to avoid clipboard issues.
+      for (const [, page] of pages) {
+        await page.evaluate(() => {
+          window.PDFViewerApplication.mlManager.isReadyFlag = false;
+        });
+
+        await switchToStamp(page);
+
+        // Add an image.
+        await copyImage(page, "../images/firefox_logo.png", 0);
+        const editorSelector = getEditorSelector(0);
+        await page.waitForSelector(editorSelector);
+        await waitForSerialized(page, 1);
+
+        // Wait for the dialog to be visible.
+        await page.waitForSelector("#newAltTextDialog", { visible: true });
+
+        // Check we haven't the disclaimer.
+        await page.waitForSelector("#newAltTextDisclaimer[hidden]");
+      }
+    });
   });
 });
diff --git a/web/genericcom.js b/web/genericcom.js
@@ -76,7 +76,8 @@ class FakeMLManager {
 
   constructor({ enableGuessAltText, enableAltTextModelDownload }) {
     this.enableGuessAltText = enableGuessAltText;
-    this.enableAltTextModelDownload = enableAltTextModelDownload;
+    this.enableAltTextModelDownload = this.isReadyFlag =
+      enableAltTextModelDownload;
   }
 
   setEventBus(eventBus, abortSignal) {
@@ -126,7 +127,7 @@ class FakeMLManager {
   }
 
   isReady(_name) {
-    return this.enableAltTextModelDownload;
+    return this.isReadyFlag;
   }
 
   guess({ request: { data } }) {

diff --git a/web/new_alt_text_manager.js b/web/new_alt_text_manager.js
@@ -346,6 +346,7 @@ class NewAltTextManager {
     this.#firstTime = firstTime;
     let { mlManager } = uiManager;
     let hasAI = !!mlManager;
+    this.#toggleTitleAndDisclaimer();
 
     if (mlManager && !mlManager.isReady("altText")) {
       hasAI = false;