Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only trigger fallback bar for forms when user interacts with page #11838

Closed
brendandahl opened this issue Apr 22, 2020 · 3 comments
Closed

Only trigger fallback bar for forms when user interacts with page #11838

brendandahl opened this issue Apr 22, 2020 · 3 comments
Labels

Comments

@brendandahl
Copy link
Contributor

We're investigating ways to show the fallback bar less. One option is only show the bar when someone clicks within a document.

@timvandermeij
Copy link
Contributor

I wondered how many times the fallback bar is still shown (since I barely see it anymore myself) and what the reasons for that are, and fortunately the new telemetry helps a lot here. The results over here are quite interesting and show that it's probably beneficial to make this change. It also gives some insights into other changes that might help here for other bars in the chart.

emalysz added a commit to emalysz/pdf.js that referenced this issue Jun 1, 2020
emalysz added a commit to emalysz/pdf.js that referenced this issue Jun 1, 2020
emalysz added a commit to emalysz/pdf.js that referenced this issue Jun 1, 2020
emalysz added a commit to emalysz/pdf.js that referenced this issue Jun 2, 2020
emalysz added a commit to emalysz/pdf.js that referenced this issue Jun 2, 2020
emalysz added a commit to emalysz/pdf.js that referenced this issue Jun 2, 2020
@bwinton
Copy link

bwinton commented Jun 3, 2020

Two questions:

  1. How hard would it be to only show the fallback bar if the user tries to interact with the form (instead of clicking anywhere in the PDF)?
  2. Will this also show the fallback bar for people who use accessibility technologies, and try to tab to the form fields?

emalysz added a commit to emalysz/pdf.js that referenced this issue Jun 3, 2020
emalysz added a commit to emalysz/pdf.js that referenced this issue Jun 3, 2020
timvandermeij added a commit that referenced this issue Jun 5, 2020
For #11838: trigger fallback bar after user clicks in pdf
@timvandermeij
Copy link
Contributor

Fixed in the pull request above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants