New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AForm validation rejects valid fields #14306

Closed

cincodenada opened this issue Nov 24, 2021 · 0 comments · Fixed by #14429 or #14430

Labels

form-js

cincodenada commented Nov 24, 2021 •

edited

Loading

Attach (recommended) or Link to PDF file here:

The PDF itself is semi-sensitive. I'm happy to provide via unsecured channels, just can't quite post it publicly.

Configuration:

Web browser and its version: Firefox 94.0.1
Operating system and its version: Mac OS 11.6
PDF.js version: Tested with 2.11.298 (in above Firefox) and git master (5e2aec7)

What is the expected behavior? (add screenshot)

I should be able to fill AForm-validated fields with valid values:

I should be able to type "123-45-6789" into an SSN field
I should be able to type "867-5309" into a phone field

What went wrong? (add screenshot)

I got validation errors instead, when trying to insert the dashes. If I try to not insert the dashes, it lets me while editing, but throws an error when leaving the field.

Additional info

For zip codes, the while-typing validation doesn't limit length - I can type as many numbers as I want, and am only complained at once I exit the field.

I've dug into this and will open a PR shortly with more details, but there are other even stranger quirks around internal deletions/insertions as well.

The text was updated successfully, but these errors were encountered:

timvandermeij added form-acroform form-xfa and removed form-acroform labels

cincodenada mentioned this issue

Fix AForm Validation for fields with non-digit characters #14307

Closed

marco-c added the form-xfa-js label

calixteman added form-js and removed form-xfa form-xfa-js labels

calixteman added a commit to calixteman/pdf.js that referenced this issue


          [JS] Fix few errors around AFSpecial_Keystroke

0a4225b

 - @cincodenada found some errors which are fixed in this patch;
 - it partially fixes issue mozilla#14306;
 - add some tests.

calixteman mentioned this issue

[JS] Fix few errors around AFSpecial_Keystroke #14429

Merged

calixteman added a commit to calixteman/pdf.js that referenced this issue


          [JS] Fix few errors around AFSpecial_Keystroke

 - @cincodenada found some errors which are fixed in this patch;
 - it partially fixes issue mozilla#14306;
 - add some tests.

This was linked to pull requests Jan 10, 2022

[JS] Fix few errors around AFSpecial_Keystroke #14429

Merged

[JS] Use beforeinput event to trigger a keystroke event in the sandbox #14430

Merged

Kafva pushed a commit to Kafva/pdf.js that referenced this issue


          [JS] Fix few errors around AFSpecial_Keystroke

48de98a

 - @cincodenada found some errors which are fixed in this patch;
 - it partially fixes issue mozilla#14306;
 - add some tests.

calixteman closed this as completed in #14430

timvandermeij mentioned this issue

error in validating Telephone number entry in pdf text field stephanrauh/ngx-extended-pdf-viewer#1146

Closed

bh213 pushed a commit to bh213/pdf.js that referenced this issue


          [JS] Fix few errors around AFSpecial_Keystroke

f453dc9

 - @cincodenada found some errors which are fixed in this patch;
 - it partially fixes issue mozilla#14306;
 - add some tests.

rousek pushed a commit to signosoft/pdf.js that referenced this issue


          [JS] Fix few errors around AFSpecial_Keystroke

b5ba7e8

 - @cincodenada found some errors which are fixed in this patch;
 - it partially fixes issue mozilla#14306;
 - add some tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment