Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inserted images do not appear in the downloaded PDF (encrypted) #16821

Closed
bstarchuk opened this issue Aug 10, 2023 · 2 comments · Fixed by #16822
Closed

Inserted images do not appear in the downloaded PDF (encrypted) #16821

bstarchuk opened this issue Aug 10, 2023 · 2 comments · Fixed by #16822
Assignees
@calixteman
Labels
annotations editor

Comments

@bstarchuk
Copy link

Attach (recommended) or Link to PDF file here:
i-9-paper-version.pdf

Configuration:

  • Web browser and its version: Chrome Version 115.0.5790.171 (Official Build) (64-bit)
  • Operating system and its version: Windows 11 Education 22H2
  • PDF.js version: 3.9.179
  • Is a browser extension: no

Steps to reproduce the problem:

  1. Open attached PDF file with PDFViewer
  2. Try insert an image into a PDF
  3. Download file

What is the expected behavior?
The inserted image should appear in the downloaded PDF
image

What went wrong?
When you open the downloaded PDF, the inserted image is not there
image
@calixteman calixteman self-assigned this Aug 10, 2023
calixteman added a commit to calixteman/pdf.js that referenced this issue Aug 10, 2023
@calixteman
[Editor] Don't forget to encrypt image streams (see issue mozilla#16821)
7a5b342 
and encrypt a compressed stream after having been compressed.
@calixteman calixteman linked a pull request Aug 10, 2023 that will close this issue
[Editor] Don't forget to encrypt image streams (see issue #16821) #16822
Merged
calixteman added a commit that referenced this issue Aug 10, 2023
@calixteman
Merge pull request #16822 from calixteman/issue16821
4be6c90 
[Editor] Don't forget to encrypt image streams (see issue #16821)
@calixteman
Copy link
Contributor

@calixteman How can I check?

Open your pdf at https://mozilla.github.io/pdf.js/web/viewer.html and edit it.

@bstarchuk
Copy link
Author

@calixteman How can I check?

Open your pdf at https://mozilla.github.io/pdf.js/web/viewer.html and edit it.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@calixteman calixteman

Labels
annotations editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Editor] Don't forget to encrypt image streams (see issue #16821) calixteman/pdf.js
2 participants
@calixteman @bstarchuk