-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use beforeEach
and afterEach
instead of initialization code in describe
blocks
#6905
Comments
We're currently using Jasmine 1.1.0 (https://github.com/mozilla/pdf.js/tree/58329f7f92f9c9f5dd8a7e42caf6ba3afdd6911d/external/jasmine), which is over 4 years old. Meanwhile Jasmine has improved a lot (in particular in the syntax for asynchronous tests, using explicit callbacks instead of error-prone |
Jasmine was updated to 2.4.1 by #7129 |
There is also |
TODO:
|
This might make the unit tests a bit slower (as we might, for example, read one file for each test instead of just once), but it is the recommended way to setup and tear down unit tests properly.
Blocked by #6877.
The text was updated successfully, but these errors were encountered: