-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace global JS unit tests file with UMD modules #7179
Labels
Comments
6 tasks
@yurydelendik Would like to give this a try if it's still open. |
Feel free to work on this! If you need help, you can contact us on IRC. |
can i work on this? |
I'm not sure if @sriranganathan is still working on this. If not, feel free to work on it! |
@timvandermeij Sir can you tell me how do i proceed? This is my first time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
(continuation of #6905, #7178 and #7172)
The unit tests (in Jasmine) can be loaded via RequireJS. We need to make them as AMD modules. Suggested naming is 'pdfjs-test/unit/file_name'.
Why UMD? I'm thinking we can reuse the same tests and run portion of them on Travis CI via node. Also we can use the same infra to validate the UMD headers.
The text was updated successfully, but these errors were encountered: