Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace global JS unit tests file with UMD modules #7179

Closed
yurydelendik opened this issue Apr 11, 2016 · 6 comments
Closed

Replace global JS unit tests file with UMD modules #7179

yurydelendik opened this issue Apr 11, 2016 · 6 comments

Comments

@yurydelendik
Copy link
Contributor

(continuation of #6905, #7178 and #7172)

The unit tests (in Jasmine) can be loaded via RequireJS. We need to make them as AMD modules. Suggested naming is 'pdfjs-test/unit/file_name'.

Why UMD? I'm thinking we can reuse the same tests and run portion of them on Travis CI via node. Also we can use the same infra to validate the UMD headers.

@sriranganathan
Copy link

@yurydelendik Would like to give this a try if it's still open.

@timvandermeij
Copy link
Contributor

Feel free to work on this! If you need help, you can contact us on IRC.

@yogupta
Copy link

yogupta commented Jan 5, 2017

can i work on this?

@timvandermeij
Copy link
Contributor

I'm not sure if @sriranganathan is still working on this. If not, feel free to work on it!

@yogupta
Copy link

yogupta commented Jan 7, 2017

@timvandermeij Sir can you tell me how do i proceed? This is my first time.

@yurydelendik
Copy link
Contributor Author

yurydelendik commented Jan 7, 2017

Currently #7934 is opened by @porlan1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants