-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore Annotations with too large border width
s, to prevent the annotationLayer
from rendering it over the surrounding document (bug 1552113)
#10877
Conversation
ce5607f
to
049f003
Compare
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/acef21b0cc250cd/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/acef21b0cc250cd/output.txt Total script time: 1.85 mins Published |
1645f47
to
73139de
Compare
…notationLayer` from rendering it over the surrounding document (bug 1552113) The border `width` will instead fallback to the default value of `1`, rather than ignoring it altoghether, to also ensure that e.g. `LinkAnnotation`s become clickable as intended. Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1552113
73139de
to
876c962
Compare
width
s to the Rect
entry, to prevent the annotationLayer
from rendering it over the surrounding document (bug 1552113)width
s, to prevent the annotationLayer
from rendering it over the surrounding document (bug 1552113)
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/766e0811943a2d2/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/5f2b3ebcd162c77/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/5f2b3ebcd162c77/output.txt Total script time: 17.83 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/766e0811943a2d2/output.txt Total script time: 25.50 mins
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/cef1f94aabfbbb3/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/cef1f94aabfbbb3/output.txt Total script time: 1.95 mins Published |
/botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/42638a30cd22e77/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/7da2a7081ecc3b5/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/7da2a7081ecc3b5/output.txt Total script time: 16.26 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/42638a30cd22e77/output.txt Total script time: 23.30 mins
|
Thank you for fixing this special case! |
The border
width
will instead fallback to the default value of1
, rather than ignoring it altoghether, to also ensure that e.g.LinkAnnotation
s become clickable as intended.Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1552113