[api-minor] Implement quadpoints for annotations in the core layer #11013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timvandermeij
force-pushed
the
annotations-quadpoints
branch
from
e599b60 to
9114004
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/aefb0172dba4a93/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 1 Live output at: http://54.215.176.217:8877/b827e377091d068/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/aefb0172dba4a93/output.txt Total script time: 17.38 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/b827e377091d068/output.txt Total script time: 25.82 mins
|
|
@Snuffleupagus Do you perhaps have time to review this? |
Sure, I'll try to take a look during the weekend. |
Snuffleupagus
approved these changes
Aug 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces the required core layer support for #6811. In a next commit, we can introduce the display layer support for this feature.
Note that four annotation types that didn't have unit tests before (because they practically didn't have any logic) now have unit tests, which is also an improvement for our unit test coverage.