Preserve error types during translation #11834
Conversation
xelan
force-pushed
the
feature/preserve-error-types
branch
from
ae8522c to
7ce370b
Compare
There was a problem hiding this comment.
This seem like way too much code/complexity for an edge-case, and in a previous PR (see #11689) the consensus was that if this should be fixed then simply re-throwing the original exception would be preferable.
|
Ok, if the possible change of the original exception outside of pdf.js is acceptable, I can just rethrow the exception with the translated message, without any cloning 😄 |
xelan
force-pushed
the
feature/preserve-error-types
branch
from
7ce370b to
d614534
Compare
|
I've pushed the updated, simplified version which rethrows the original exception. |
By preserving the exception type, more fine-grained error handling can be performed via client-side logic (e.g. redirect to a search page if a PDF is not found, or to a ticket system in case of invalid PDF files). The original exception is now re-thrown. Fixes mozilla#11658
xelan
force-pushed
the
feature/preserve-error-types
branch
from
d614534 to
f5fd24a
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/4ab244e9adc073f/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/4ab244e9adc073f/output.txt Total script time: 3.34 mins Published |
|
Let's do this. Thank you for your contribution! |
Great 👍 You're welcome. Thanks for the feedback and the quick and professional handling. |
By preserving the exception type, more fine-grained error handling can be performed via client-side logic (e.g. redirect to a search page if a PDF is not found, or to a ticket system in case of invalid PDF files).
The original exception type and its properties (e.g. status code) are preserved by cloning the error object and assigning the translated message. Note that only a shallow clone is performed for simplicity.
Fixes #11658