Move the opening of PDF file attachments into the DownloadManager-implementations
#13009
Conversation
…mplementations Note how the `PDFAttachmentViewer` handles PDF file attachments specially, by opening them in a new window/tab, rather than forcing them to be downloaded. This is done to improve the overall UX, since browsers in general are able to handle PDF files internally. However, for file *annotations* we're currently not attempting to do the same thing and are instead just downloading them directly. In order to unify the behaviour, without having to duplicate a lot of code, the opening of PDF file attachments is thus moved into a new `DownloadManager.openOrDownloadData` method.
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/9a6aa4e716db3f3/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/18e0dd53c5c7b7d/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/9a6aa4e716db3f3/output.txt Total script time: 3.63 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/18e0dd53c5c7b7d/output.txt Total script time: 6.40 mins
|
|
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/5e7c29b0705adc6/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/4a9b92ff305df22/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/4a9b92ff305df22/output.txt Total script time: 3.08 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/5e7c29b0705adc6/output.txt Total script time: 4.62 mins
|
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/c161f6e937bb140/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/c161f6e937bb140/output.txt Total script time: 4.04 mins Published |
|
Thank you for improving this! |
Note how the
PDFAttachmentViewerhandles PDF file attachments specially, by opening them in a new window/tab, rather than forcing them to be downloaded. This is done to improve the overall UX, since browsers in general are able to handle PDF files internally.However, for file annotations we're currently not attempting to do the same thing and are instead just downloading them directly. In order to unify the behaviour, without having to duplicate a lot of code, the opening of PDF file attachments is thus moved into a new
DownloadManager.openOrDownloadDatamethod.