Ensure that Dict.set only accepts string keys
#14597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
force-pushed
the
Dict-set-validate-key
branch
3 times, most recently
from
52be88c to
452c2ed
Compare
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/32344fd2ee6d770/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/6b93221a01d6dd0/output.txt |
Trying to use a non-string `key` in a `Dict` is not intended, and would basically be an implementation error. Hence we can add a non-PRODUCTION check to enforce this, complementing the existing `value` check added in PR 11672.
Snuffleupagus
force-pushed
the
Dict-set-validate-key
branch
from
452c2ed to
a2f9031
Compare
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/6b93221a01d6dd0/output.txt Total script time: 24.18 mins
Image differences available at: http://54.241.84.105:8877/6b93221a01d6dd0/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/32344fd2ee6d770/output.txt Total script time: 24.61 mins
|
timvandermeij
approved these changes
Feb 23, 2022
|
Good idea; let's do this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to use a non-string
keyin aDictis not intended, and would basically be an implementation error. Hence we can add a non-PRODUCTION check to enforce this, complementing the existingvaluecheck added in PR #11672.