-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid the preprocess
-function adding consecutive blank lines
#14904
Avoid the preprocess
-function adding consecutive blank lines
#14904
Conversation
When pre-processor blocks are being removed, since they don't apply to the current build target, we may currently end up with consecutive blank lines. While this is obviously not a big issue, it's nonetheless undesirable and we can adjust the `writeLine` function to prevent that.
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/cff3f1999137808/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/948881f2b4d2131/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/948881f2b4d2131/output.txt Total script time: 4.29 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/cff3f1999137808/output.txt Total script time: 7.97 mins
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/ea26299c6081ff6/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/ea26299c6081ff6/output.txt Total script time: 2.56 mins Published |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
When pre-processor blocks are being removed, since they don't apply to the current build target, we may currently end up with consecutive blank lines.
While this is obviously not a big issue, it's nonetheless undesirable and we can adjust the
writeLine
function to prevent that.